Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments so dockerfiles can be updated by update-base-images #46

Merged
merged 3 commits into from
Dec 7, 2022
Merged

Add comments so dockerfiles can be updated by update-base-images #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec3d8c0
Add comments so dockerfiles can be updated by update-base-images
SDawley Dec 5, 2022
e3db116
publish a :latest tag too
nickboldt Dec 6, 2022
7b3c8bc
cannot use updateBaseImages.sh on SHA-based tags as they're not date-…
nickboldt Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ubi8-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
push: ${{ github.event_name != 'pull_request' }}
context: base/ubi8
tags: |
quay.io/devfile/base-developer-image:latest
${{ steps.meta.outputs.tags }}

build_universal_ubi8_image:
Expand Down
3 changes: 2 additions & 1 deletion base/ubi8/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# syntax=docker/dockerfile:1.3-labs

FROM registry.access.redhat.com/ubi8/ubi
# https://registry.access.redhat.com/ubi8
FROM registry.access.redhat.com/ubi8/ubi:8.7-1026
LABEL maintainer="Red Hat, Inc."

LABEL com.redhat.component="devfile-base-container"
Expand Down
1 change: 1 addition & 0 deletions universal/ubi8/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# syntax=docker/dockerfile:1.3-labs

# updateBaseImages.sh can't operate on SHA-based tags as they're not date-based or semver-sequential, and therefore cannot be ordered
FROM quay.io/devfile/base-developer-image:ubi8-latest
LABEL maintainer="Red Hat, Inc."

Expand Down