feat: Support for SHA-384 Provisioning Certificates in rpc-go #1078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jena-satyabrata
requested review from
divneil-intel,
graikhel-intel,
lejin-joy,
madhavilosetty-intel,
rabipaikaray and
rsdmike
jena-satyabrata
force-pushed
the
feat/issue971
branch
7 times, most recently
from
138f7d3 to
356f4bb
Compare
jena-satyabrata
changed the title
There was a problem hiding this comment.
Pull request overview
This PR adds support for SHA-384 hash algorithm for provisioning certificates in the rpc-go library, expanding beyond the previous SHA-256-only support. The implementation aligns the hash algorithm handling between certificate validation and AMT communication.
Key Changes:
- Updated hash algorithm interpretation to map value 3 to SHA-384 (48 bytes) and shifted SHA-512 to value 5
- Modified certificate hash generation to support both SHA-256 and SHA-384 based on certificate algorithm
- Enhanced certificate hash comparison to compute and match against multiple hash algorithms (SHA-256 and SHA-384)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/utils/helper.go | Updated InterpretHashAlgorithm to correctly map algorithm codes: 3→SHA-384, 5→SHA-512 |
| pkg/utils/helper_test.go | Updated test cases to reflect new hash algorithm mappings |
| internal/local/activate.go | Added SHA-384 hash generation in StartSecureHostBasedConfiguration and multi-algorithm fingerprint comparison in CompareCertHashes |
| internal/local/activate_test.go | Added comprehensive test coverage for SHA-256/SHA-384 certificate handling and hash comparison scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jena-satyabrata
force-pushed
the
feat/issue971
branch
from
356f4bb to
df40b95
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Updated InterpretHashAlgorithm to handle SHA-384 (case 3) and SHA-512 (case 5) - Added SHA-384 support in StartSecureHostBasedConfiguration - Enhanced CompareCertHashes to compute and match both SHA-256 and SHA-384 fingerprints - Added test coverage for SHA-384 certificate handling Signed-off-by: Jena, Satyabrata <[email protected]>
jena-satyabrata
force-pushed
the
feat/issue971
branch
from
df40b95 to
e5f6067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.