Skip to content

refactor: rename presentation workflow helpers#222

Merged
devkade merged 1 commit into
devfrom
refactor/issue-209-presentation-registration-names
May 17, 2026
Merged

refactor: rename presentation workflow helpers#222
devkade merged 1 commit into
devfrom
refactor/issue-209-presentation-registration-names

Conversation

@devkade
Copy link
Copy Markdown
Owner

@devkade devkade commented May 17, 2026

Summary

  • rename generic presentation registration helpers away from Kapi*/kapi* implementation names
  • keep public kapi_* agent tools, /kapi-* slash commands, widget keys, and compatibility contracts unchanged
  • update the product-name audit with the new presentation-helper guard

Refs #209

Verification

  • npm test
  • npm run check
  • npm run check:unused
  • npm run quality:budgets

Residual scan

rg -n 'registerKapi|installKapi|toggleKapi|KapiUi|kapiTool|KAPI_EXTENSION|kapiWidget|\bfunction kapi\b' src/presentation index.ts test/presentation-ui.test.ts
# no matches

find src -iname '*kapi*' -print
src/cli/kapi-review-cli.ts
src/.kapi
src/.kapi/lanes/kapi-autoresearch
src/.kapi/lanes/kapi-autoresearch/kapi-ux-개선-계획

@devkade
Copy link
Copy Markdown
Owner Author

devkade commented May 17, 2026

@kapi-agent review

Head SHA: d80ae9c

What changed:

  • Renamed generic presentation registration/action helpers from product-prefixed names to semantic workflow names.
  • Kept public kapi_* agent tool names, /kapi-* slash commands, widget keys, and persisted compatibility contracts intact.
  • Updated docs/product-name-audit.md with the new guard.

Why this closes prior feedback:

Verification:

  • npm test
  • npm run check
  • npm run check:unused
  • npm run quality:budgets

Residual scan:

rg -n 'registerKapi|installKapi|toggleKapi|KapiUi|kapiTool|KAPI_EXTENSION|kapiWidget|\bfunction kapi\b' src/presentation index.ts test/presentation-ui.test.ts
# no matches

find src -iname '*kapi*' -print
src/cli/kapi-review-cli.ts
src/.kapi
src/.kapi/lanes/kapi-autoresearch
src/.kapi/lanes/kapi-autoresearch/kapi-ux-개선-계획

Copy link
Copy Markdown

@kapi-agent kapi-agent Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kapi-agent review

Verdict: APPROVE

Final approval summary

Review journey

This PR’s original goal is a narrow refactor: rename presentation-layer helper symbols away from product-specific Kapi* / kapi* implementation names while preserving public kapi_* tools, /kapi-* slash commands, widget keys, and serialized compatibility contracts. The semantic scope is bounded to internal presentation registration/UI helper naming plus the audit documentation. There was no prior kapi-agent review on this head, so no fix ping-pong was required.

What changed

Key internal names were updated across:

  • index.ts
  • src/presentation/pi-extension.ts
  • src/presentation/extension-registration.ts
  • src/presentation/tools.ts
  • src/presentation/tool-core-types.ts
  • src/presentation/ui.ts
  • src/presentation/ui-resources.ts
  • src/presentation/command-ui-actions.ts
  • test/presentation-ui.test.ts
  • docs/product-name-audit.md

The external contracts remain intentionally unchanged: kapi_* tool names, /kapi-* commands, "kapi" UI status/widget keys, and Kapi-facing user messages.

Why this is correct

The change is mechanically consistent with the audit goal and does not alter runtime behavior. Internal imports/exports were renamed together, tests were updated to reference the semantic helper names, and the PR preserves compatibility surfaces that should not be renamed without migration.

Evidence

Verifier gate: PASS. Size gate: PASS, 93 changed lines under the 200-line semantic review threshold. Revision-explanation status: not required and found. The configured verification ran successfully with npm ci && npm run verify, including tests, type/check gates, unused checks, and quality budgets. The Ilchul structured review harness passed with no blocking findings. I also inspected the changed presentation files and searched for stale renamed helper references.

Remaining risks and approval rationale

Remaining risk is low and limited to whether any external extension loader depends on the default export function’s runtime name in index.ts; that would be unusual, and the module still exports the same default function shape. Given passing verification, consistent internal renames, preserved public contracts, and updated audit documentation, approval is justified.

Blocking issues

None.

Warnings / risks

  • index.ts: the default export function was renamed from kapi to extension. This should be safe for normal default-export loading, but if any out-of-band tooling introspects function names, that would be a minor compatibility risk.

Suggestions

  • Consider adding a small smoke/assertion test for the extension entrypoint default export shape if the Pi extension loader contract is sensitive to entrypoint behavior.

Looks good

  • Public contracts were preserved while internal helper names were made semantic.
  • The rename is consistent across imports, exports, tests, and audit documentation.
  • The residual scan described in the PR body matches the intended boundary between compatibility/product surfaces and reusable implementation names.

Verification notes

Verifier gate status: PASS — npm ci && npm run verify exited 0.
Size gate status: PASS — 93 changed lines, below threshold.
Revision-explanation status: not required; explanation present in the PR body.
Ilchul harness gate: PASS — neutral/comment result with zero blocking findings.


Engine: pi

@devkade devkade merged commit 92f5ff8 into dev May 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant