Skip to content

fix(Week.cs): correct the starting day of the week calculation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MafistoPL wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(Week.cs): correct the starting day of the week calculation #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/MySpot.Core/ValueObjects/Week.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ public Week(DateTimeOffset value)
{
var pastDays = value.DayOfWeek is DayOfWeek.Sunday ? 7 : (int) value.DayOfWeek;
var remainingDays = 7 - pastDays;
From = new Date(value.AddDays(-1 * pastDays));
From = new Date(value.AddDays(-1 * pastDays + 1));
To = new Date(value.AddDays(remainingDays));
}

Expand Down
30 changes: 30 additions & 0 deletions tests/MySpot.Tests.Unit/ValueObjects/WeekTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
using System;
using MySpot.Core.ValueObjects;
using Shouldly;
using Xunit;

namespace MySpot.Tests.Unit.ValueObjects;

public class WeekTests
{
[Theory]
[InlineData("2023-08-13", "2023-08-07", "2023-08-13")]
[InlineData("2023-08-14", "2023-08-14", "2023-08-20")]
[InlineData("2023-08-15", "2023-08-14", "2023-08-20")]
[InlineData("2023-08-16", "2023-08-14", "2023-08-20")]
[InlineData("2023-08-17", "2023-08-14", "2023-08-20")]
[InlineData("2023-08-18", "2023-08-14", "2023-08-20")]
[InlineData("2023-08-19", "2023-08-14", "2023-08-20")]
[InlineData("2023-08-20", "2023-08-14", "2023-08-20")]
[InlineData("2023-08-21", "2023-08-21", "2023-08-27")]
public void given_datetime_offset_should_create_proper_week(
string dateString, string fromDateString, string toDateString)
{
var dateTime = DateTime.Parse(dateString);

var week = new Week(dateTime);

week.From.Value.ToString("yyyy-MM-dd").ShouldBe(fromDateString);
week.To.Value.ToString("yyyy-MM-dd").ShouldBe(toDateString);
}
}