Skip to content

fix: SPDX LicenseRef, gate enforcement, middleware diagram#24

Merged
devonartis merged 1 commit into
developfrom
fix/spdx-and-diagram-corrections
Apr 13, 2026
Merged

fix: SPDX LicenseRef, gate enforcement, middleware diagram#24
devonartis merged 1 commit into
developfrom
fix/spdx-and-diagram-corrections

Conversation

@devonartis

Copy link
Copy Markdown
Owner

Summary

Fixes three findings from code review:

  • P2 — SPDX identifier: PolyForm-Internal-Use-1.0.0 is not on the SPDX License List. Changed to LicenseRef-PolyForm-Internal-Use-1.0.0 across LICENSE + 77 Go files per SPDX spec for unlisted licenses.
  • P2 — Gate enforcement: CI SPDX check now validates the exact expected identifier, not just presence of SPDX-License-Identifier:. Mirrored in scripts/gates.sh.
  • P3 — Middleware diagram: Mermaid flowchart corrected to match cmd/broker/main.go wrapping order: RequestID → Logging → MaxBytesBody → SecurityHeaders → mux.

Test plan

  • go build ./... passes
  • go test ./... -short all packages pass
  • SPDX gate check passes locally with new exact-match logic
  • CI gates-passed green

P2: PolyForm Internal Use 1.0.0 is not on the SPDX License List.
Changed identifier to LicenseRef-PolyForm-Internal-Use-1.0.0 across
LICENSE and all 77 Go files per SPDX spec for unlisted licenses.

P2: CI SPDX gate now checks the exact expected identifier string,
not just presence of SPDX-License-Identifier:. Mirrored in gates.sh.

P3: Middleware stack mermaid diagram corrected to match actual
wrapping order in cmd/broker/main.go:
RequestID → Logging → MaxBytesBody → SecurityHeaders → mux.
@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 92842ce.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@devonartis devonartis merged commit 448db8d into develop Apr 13, 2026
21 checks passed
@devonartis devonartis deleted the fix/spdx-and-diagram-corrections branch April 13, 2026 19:04
devonartis added a commit that referenced this pull request Apr 13, 2026
Missed spots from PR #24's LicenseRef rename:
- Dockerfile OCI label (org.opencontainers.image.licenses)
- docs/api/openapi.yaml license name field
- docs/getting-started-operator.md OCI label reference
- CHANGELOG.md historical entries updated to match corrected value

Verified: zero bare PolyForm-Internal-Use-1.0.0 identifiers remain
outside of human-readable prose ("PolyForm Internal Use License 1.0.0").
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant