Fix state upgrade panic; migrate legacy attribute; add tests - #124
Merged
Conversation
Updated state upgrade logic to handle attribute rename from 'destroy_parameters' to 'destroy_request_parameters'. Added manual state extraction for compatibility with v0.
Added helper functions to extract values from raw state during upgrade and modified state extraction logic to handle missing attributes more robustly.
Add tests for state upgrade handling of destroy parameters
Owner
|
Thanks for this. Truly appreciated. I'll get this review done by tomorrow latest. It's an honour to have your contribution |
Owner
|
@IonutLupsan Thanks again for doing this. The linter is failing on line 971 of the test. It looks like you assign the variable |
Contributor
Author
|
Hopefully everything is fine now. |
Contributor
Author
|
Following up on loose ends - can you re-run the action again ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes: