fix: improve read support (merge conflict resolution for #149) - #157
Closed
devops-rob wants to merge 3 commits into
Closed
fix: improve read support (merge conflict resolution for #149)#157devops-rob wants to merge 3 commits into
devops-rob wants to merge 3 commits into
Conversation
The responseCodeChecker method now takes raw parameters and does more work: convert them and check the values The resulting code is easier to use Signed-off-by: Alexandre Bruyelles <git@jack.fr.eu.org>
ReadResponseCodes was never actually used Also, improve the situation when oldSanitized is null (aka: we just created the object) Signed-off-by: Alexandre Bruyelles <git@jack.fr.eu.org>
Resolve utilities.go conflict: keep sensitive response helpers from main and responseCodeChecker(types.List, int) refactor from #149. Update curl_action.go to use the refactored checker signature. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
Superseded by fixes pushed directly to #149 (JackSlateur/fix/drift). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves merge conflicts from #149 onto current
main.responseCodeChecker(types.List, int)refactor from fix: improve read support #149read_response_codesstatus in addition to body comparisoncurl_action.gofor refactored checker signatureSupersedes / replaces conflict resolution for #149 by @JackSlateur.
Test plan
go build ./...Made with Cursor