GenericRepository: fix unpickling of objects #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows them to be passed across process boundaries when using `concurrent.futures.ProcessPoolExecutor`. Without this, a `RecursionError` occurs. The issue stems from `GenericRepository.__getattr__` calling `getattr(self.path, ...)`. `GenericRepository.path` is a property, so it is found, but it then calls `self._artifactory.joinpath(...)` and `self._artifactory` is not yet present on the partially-restored `GenericRepository`, resulting in a call to `GenericRepository.__getattr__`, etc. This fix ensures that `self._artifactory` will be restored to the object early enough in unpickling to avoid the issue.
|
TY! 🫶 |
|
@allburov Thank you for the speedy review and merge! Would it be possible to cut a new release including this fix? |
|
Actually, scratch that: it seems that we don't retain |
|
I believe #456 will address that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows them to be passed across process boundaries when using
concurrent.futures.ProcessPoolExecutor. Without this, aRecursionErroroccurs.The issue stems from
GenericRepository.__getattr__callinggetattr(self.path, ...).GenericRepository.pathis a property, so it is found, but it then callsself._artifactory.joinpath(...)andself._artifactoryis not yet present on the partially-restoredGenericRepository, resulting in a call toGenericRepository.__getattr__, etc.This fix ensures that
self._artifactorywill be restored to the object early enough in unpickling to avoid the issue.