Python 3.13 compatibility. #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Between Python 3.12 and Python 3.13, the internal structure of pathlib changed, causing the Artifactory URL parsing to fail. `pathlib.PurePath` previously had a private class attribute, `_flavour`, which has now been renamed to `parser` and made into a public and documented API. This renames `_flavour` to `parser` in the ArtifactoryPath subclasses, but it leaves around a `_flavour` class attribute that is aliased to `parser` as a compatibility shim for older versions of Python. One other breakage between Python 3.12 and 3.13 is that the artifactory package attempted to import `posixpath` via the `pathlib` package. `posixpath` was never meant to be a publicly accessible attribute of `pathlib`, as `posixpath` is its own top-level package in the standard library. The `pathlib` code was significantly restructured, causing the `posixpath` module to no longer be accessible under `pathlib`. We fix this in artifactory by directly importing the top-level `posixpath` package. Finally, this adds Python 3.13 to the package metadata in setup.py and the tox and GitHub Actions configuration files so that it is officially declared as a supported Python version and tested in CI.
allburov
approved these changes
Feb 21, 2025
|
Thanks! This fixes the parsing issue. However, running a minimal script with a loop resulted in an AttributeError: from artifactory import ArtifactoryPath
path = ArtifactoryPath("https://mysite/artifactory")
for p in path:
print(path)Raises UpdateReplacing the call to |
|
@offa thank you for the fix! Could you create a PR to Let's have a dedicated branch, so we don't have to push in forks the hotfixes and we'll release it when it's stable for all! |
|
Thank you for the quick review! Really appreciate it! |
allburov
added a commit
that referenced
this pull request
Apr 8, 2025
* Python 3.13 compatibility. (#473) Between Python 3.12 and Python 3.13, the internal structure of pathlib changed, causing the Artifactory URL parsing to fail. `pathlib.PurePath` previously had a private class attribute, `_flavour`, which has now been renamed to `parser` and made into a public and documented API. This renames `_flavour` to `parser` in the ArtifactoryPath subclasses, but it leaves around a `_flavour` class attribute that is aliased to `parser` as a compatibility shim for older versions of Python. One other breakage between Python 3.12 and 3.13 is that the artifactory package attempted to import `posixpath` via the `pathlib` package. `posixpath` was never meant to be a publicly accessible attribute of `pathlib`, as `posixpath` is its own top-level package in the standard library. The `pathlib` code was significantly restructured, causing the `posixpath` module to no longer be accessible under `pathlib`. We fix this in artifactory by directly importing the top-level `posixpath` package. Finally, this adds Python 3.13 to the package metadata in setup.py and the tox and GitHub Actions configuration files so that it is officially declared as a supported Python version and tested in CI. * Replace _make_child_relpath() with public joinpath() (#475) * Add unit test for `glob()` and partially fix Python 3.13 case. (#476) * Add unit test for `glob()` and partially fix Python 3.13 case. * Add custom subclass of _Globber to fix remaining issues with glob behavior. * Guard _globber override with Python version check. Co-authored-by: allburov <[email protected]> * Rearrange `if` statement to prefer early returns. Co-authored-by: allburov <[email protected]> * Add comment linking to original code for recursive_selector(). --------- Co-authored-by: allburov <[email protected]> --------- Co-authored-by: Richard Xia <[email protected]> Co-authored-by: offa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #470.
Between Python 3.12 and Python 3.13, the internal structure of pathlib changed, causing the Artifactory URL parsing to fail.
pathlib.PurePathpreviously had a private class attribute,_flavour, which has now been renamed toparserand made into a public and documented API.This renames
_flavourtoparserin the ArtifactoryPath subclasses, but it leaves around a_flavourclass attribute that is aliased toparseras a compatibility shim for older versions of Python.One other breakage between Python 3.12 and 3.13 is that the artifactory package attempted to import
posixpathvia thepathlibpackage.posixpathwas never meant to be a publicly accessible attribute ofpathlib, asposixpathis its own top-level package in the standard library. Thepathlibcode was significantly restructured, causing theposixpathmodule to no longer be accessible underpathlib. We fix this in artifactory by directly importing the top-levelposixpathpackage.Finally, this adds Python 3.13 to the package metadata in setup.py and the tox and GitHub Actions configuration files so that it is officially declared as a supported Python version and tested in CI.