Skip to content

fix(cumple): use display name (nickname) instead of real username#761

Merged
hectorpalmatellez merged 1 commit into
masterfrom
fix/cumple-display-name
May 21, 2026
Merged

fix(cumple): use display name (nickname) instead of real username#761
hectorpalmatellez merged 1 commit into
masterfrom
fix/cumple-display-name

Conversation

@gmq
Copy link
Copy Markdown
Member

@gmq gmq commented May 21, 2026

Summary

  • The birthday script was storing and displaying msg.message.user.name (the real Slack username) instead of the user's display name/nickname
  • Added a getDisplayName helper that reads user.slack.profile.display_name with a fallback to user.name, following the same pattern used in poll.js
  • The brain key still uses the real username for stable lookups; only the displayed user field uses the nickname

Test plan

  • Run huemul cumple set DD/MM and confirm the confirmation message and subsequent hoy/mes/lista outputs show the nickname, not the real username
  • Confirm huemul cumple delete still removes the correct entry
  • Existing unit tests pass (fallback to .name applies in test environments where user.slack is undefined)

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@gmq gmq requested a review from a team as a code owner May 21, 2026 23:28
@gmq gmq requested a review from catuga May 21, 2026 23:28
@hectorpalmatellez hectorpalmatellez merged commit 09a22d0 into master May 21, 2026
3 checks passed
@hectorpalmatellez hectorpalmatellez deleted the fix/cumple-display-name branch May 21, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants