Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Release v3.5.13 #1

Open
wants to merge 81 commits into
base: release-v3.5.10
Choose a base branch
from
Open

Conversation

RajeevRanjan27
Copy link

v3.5.10 -> v3.5.13

isubasinghe and others added 30 commits September 20, 2024 10:28
)

Signed-off-by: Alan Clucas <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
Co-authored-by: Anton Gilgur <[email protected]>
…#12787)

Signed-off-by: Ingvar Mattsson <[email protected]>
Signed-off-by: Ingvar <[email protected]>
Co-authored-by: Ingvar Mattsson <[email protected]>
Co-authored-by: Anton Gilgur <[email protected]>
agilgur5 and others added 26 commits September 20, 2024 14:42
- this is a partial cherry-pick of 4b47f43, specifically only the changes to _existing_ features
  - they are a good improvement over the previous docs, IMO

Signed-off-by: Anton Gilgur <[email protected]>
Co-authored-by: Kavish Nareshchandra Dahekar <[email protected]>
Co-authored-by: Kavish Dahekar <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
(cherry picked from commit 0c65450)
- this is a partial backport of 7a23cb0, specifically only the docs for _existing_ features
  - this is a useful feature that was previously undocumented

Signed-off-by: Anton Gilgur <[email protected]>
- I left one line of markdown in in a34d989 accidentally due to an improper copy+paste of the diff

Signed-off-by: Anton Gilgur <[email protected]>
- fixed one merge conflict with the `pull_request_template.md` where the Sustainability Effort mention was not backported to release-3.5

Signed-off-by: Anton Gilgur <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
(cherry picked from commit 2e9c1ca)
* fix(api): properly authorize GET workflow fallback to archive

- the authorization was accidentally removed in argoproj@f1ab5aa

- also if no archived workflow is found, properly return the original error as per argoproj@ac9e2de

Signed-off-by: Anton Gilgur <[email protected]>

* test: add permission assertions for GET WF archived fallback

- the permission suite seemed to not have previously tested this
- add good, bad, and fake token checks
  - where "bad" is valid, but unauthorized, while "fake" is valid in format, but not corresponding to a real token

Signed-off-by: Anton Gilgur <[email protected]>

* fix(test): assign `goodToken` initially

- these tests were relying on ordering of assignments before, i.e. 1. good 2. bad 3. bad
  - should just assign before each test instead for simplicity / less complexity / less mistakes

Signed-off-by: Anton Gilgur <[email protected]>

---------

Signed-off-by: Anton Gilgur <[email protected]>
Co-authored-by: Anton Gilgur <[email protected]>
@RajeevRanjan27 RajeevRanjan27 changed the base branch from release-v3.5.10 to main December 26, 2024 14:34
@RajeevRanjan27 RajeevRanjan27 changed the base branch from main to release-v3.5.10 December 26, 2024 18:43
@RajeevRanjan27 RajeevRanjan27 changed the title Release v3.5.13 fix: Release v3.5.13 Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.