Skip to content

Commit

Permalink
Merge pull request #2277 from devtron-labs/fix/cluster-readme
Browse files Browse the repository at this point in the history
fix: cluster description not authorized issue
  • Loading branch information
eshankvaish authored Dec 11, 2024
2 parents 84162c5 + 9ac2af1 commit fdd962c
Showing 1 changed file with 8 additions and 21 deletions.
29 changes: 8 additions & 21 deletions src/components/common/Description/GenericDescription.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -108,16 +108,14 @@ export default function GenericDescription({
}

const toggleDescriptionView = () => {
if (isAuthorized()) {
let isConfirmed: boolean = true
if (isDescriptionModified) {
isConfirmed = window.confirm(CLUSTER_DESCRIPTION_UNSAVED_CHANGES_MSG)
}
if (isConfirmed) {
setModifiedDescriptionText(descriptionText)
setEditDescriptionView(!isEditDescriptionView)
setSelectedTab(MD_EDITOR_TAB.WRITE)
}
let isConfirmed: boolean = true
if (isDescriptionModified) {
isConfirmed = window.confirm(CLUSTER_DESCRIPTION_UNSAVED_CHANGES_MSG)
}
if (isConfirmed) {
setModifiedDescriptionText(descriptionText)
setEditDescriptionView(!isEditDescriptionView)
setSelectedTab(MD_EDITOR_TAB.WRITE)
}
}

Expand All @@ -129,17 +127,6 @@ export default function GenericDescription({
}
}

const isAuthorized = (): boolean => {
if (isClusterTerminal) {
ToastManager.showToast({
variant: ToastVariantType.notAuthorized,
description: TOAST_ACCESS_DENIED.SUBTITLE,
})
return false
}
return true
}

const updateApplicationAbout = (): void => {
const isValidate = validateDescriptionText()
if (!isValidate) {
Expand Down

0 comments on commit fdd962c

Please sign in to comment.