Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Mandatory Tags Enforcement #2234

Merged
merged 71 commits into from
Dec 20, 2024
Merged

feat: Mandatory Tags Enforcement #2234

merged 71 commits into from
Dec 20, 2024

Conversation

shivani170
Copy link
Contributor

@shivani170 shivani170 commented Nov 27, 2024 •
edited by arunjaindev
Loading

Description

Tasks:

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1188

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@shivani170 shivani170 changed the title feat: navigation text change feat: Mandatory Tags Enforcement Nov 27, 2024
@github-actions github-actions bot added the PR:Issue-verification-failed PR:Issue-verification-failed label Dec 4, 2024
arunjaindev and others added 15 commits December 4, 2024 13:06
@arunjaindev
Merge branch 'feat/mandatory-tags-v2' of https://github.com/devtron-l…
48316c4 
…abs/dashboard into feat/mandatory-tags-cd
@shivani170
chore: version bump 1.1.7-beta-7
f23da91
@shivani170
chore: Updated common lib 1.1.7-beta-8
ff0abd5
@shivani170
Merge branch 'develop' into feat/mandatory-tags-v2
388c963
@arunjaindev
Merge branch 'feat/mandatory-tags-v2' of https://github.com/devtron-l…
00c6b68 
…abs/dashboard into feat/mandatory-tags-cd
@shivani170
chore: version bump to 1.2.2-beta-2
ed0946f
@shivani170
chore: remove this later
a6b3026
@arunjaindev
feat: use dynamic data table for mandatory and
78742f6 
 tags in create and update tags
@arunjaindev
feat: add support for configured tags
9759ae8
@arunjaindev
chore: move policy consequences api into promise.all
878c4bc
@arunjaindev
Merge branch 'feat/mandatory-tags-cd' of https://github.com/devtron-l…
f467956 
…abs/dashboard into feat/create-edit-app-tags
@arunjaindev
chore: version bump
321ba55
@shivani170
Merge branch 'develop' into feat/mandatory-tags-v2
e279ecb
@shivani170
chore: version bump to 1.2.4-beta-2
443fbc3
@shivani170
Merge branch 'feat/mandatory-tags-v2' into feat/mandatory-tags-cd
eb7d13c
RohitRaj011
RohitRaj011 requested changes Dec 6, 2024
View reviewed changes
@shivani170 shivani170 self-assigned this Dec 18, 2024
arunjaindev and others added 11 commits December 18, 2024 16:43
@vivek-devtron vivek-devtron changed the base branch from develop to main December 19, 2024 14:55
vivek-devtron
vivek-devtron previously approved these changes Dec 19, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions github-actions bot added PR:Ready-to-Review PR:Ready-to-Review and removed PR:Issue-verification-failed PR:Issue-verification-failed labels Dec 20, 2024
@arunjaindev arunjaindev merged commit 526c636 into main Dec 20, 2024
9 of 11 checks passed
@arunjaindev arunjaindev deleted the feat/mandatory-tags-v2 branch December 20, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshankvaish eshankvaish eshankvaish approved these changes

@vivek-devtron vivek-devtron vivek-devtron approved these changes

@RohitRaj011 RohitRaj011 RohitRaj011 left review comments

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

Assignees

@shivani170 shivani170

Labels
PR:Ready-to-Review PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shivani170 @eshankvaish @RohitRaj011 @vivek-devtron @arunjaindev