feat: redirect non super admin to config maps in configuration view instead of Deployment template #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhishekA1509
requested review from
vivek-devtron and
vikramdevtron
as code owners
github-actions
bot
added
PR:Issue-verification-failed
…from navlinks for config redirection to serve as base for redirection
…p and env override
…UTE for environment configurations
…used type interface
AbhishekA1509
commented
Feb 10, 2025
AbhishekA1509
commented
Feb 10, 2025
AbhishekA1509
commented
Feb 10, 2025
src/Pages/Applications/DevtronApps/Details/AppConfigurations/Navigation/AppNavigation.tsx
Show resolved
Hide resolved
AbhishekA1509
commented
Feb 10, 2025
...Pages/Applications/DevtronApps/Details/AppConfigurations/Navigation/EnvConfigurationsNav.tsx
Show resolved
Hide resolved
AbhishekA1509
commented
Feb 10, 2025
...Pages/Applications/DevtronApps/Details/AppConfigurations/Navigation/EnvConfigurationsNav.tsx
Show resolved
Hide resolved
RohitRaj011
previously approved these changes
Feb 11, 2025
feat: add base-config path segment for base configurations
vivek-devtron
previously approved these changes
Feb 12, 2025
…nifest and PipelineStrategy
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR handles changes to enable redirection for non super admin to config maps in configuration view instead of Deployment template when there are few CM's present by splitting the suffix of resourceType from nav url, and on getting the data from API would re-direct to a valid resourceType.
Fixes https://github.com/devtron-labs/sprint-tasks/issues/1883
Type of change
How Has This Been Tested?
QA
Checklist: