feat: react router v6 by arunjaindev · Pull Request #3059 · devtron-labs/dashboard

arunjaindev · 2026-02-13T11:41:54Z

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test A
Test B

Checklist:

The title of the PR states what changed and the related issues number (used for the release note).
Does this PR require documentation updates?
I've updated documentation as required by this PR.
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas

…oard into feat/react-router-v6

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

AbhishekA1509 · 2026-02-16T13:11:03Z

...ils/AppConfigurations/MainContent/DeploymentConfigCompare/DeploymentConfigCompareWrapper.tsx

+        ) {
+            return `${baseGoBackURL}${appendEnvOverridePath ? envOverridePath : ''}`
+        }
+        return `${baseGoBackURL}${appendEnvOverridePath ? envOverridePath : ''}/${currentResourceType}${currentResourceName ? `/${currentResourceName}` : ''}`


${baseGoBackURL}${appendEnvOverridePath ? envOverridePath : ''} could be a variable

AbhishekA1509 · 2026-02-16T13:11:31Z

...ils/AppConfigurations/MainContent/DeploymentConfigCompare/DeploymentConfigCompareWrapper.tsx

+    const getNavItemHref = (resourceType: EnvResourceType, resourceName: string) =>
+        `${generatePath(routePath, { ...params, resourceType, resourceName })}${location.search}`
+
+    const calculatedGoBackURL = useMemo(() => {


is memo required here?

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

…improve response parsing

AbhishekA1509 · 2026-02-17T06:14:16Z

...Pages/Applications/DevtronApps/Details/AppConfigurations/Navigation/EnvConfigurationsNav.tsx

+                {
+                    appId,
+                    envId,
+                    ...params,


appId and envId should be after params right?

AbhishekA1509 · 2026-02-17T06:14:29Z

...Pages/Applications/DevtronApps/Details/AppConfigurations/Navigation/EnvConfigurationsNav.tsx

+                {
+                    appId,
+                    envId,
+                    ...params,


AbhishekA1509 · 2026-02-17T06:26:11Z

src/App.tsx

        setGlobalAPITimeout(window._env_.GLOBAL_API_TIMEOUT)
    }, [])

-    useEffect(() => {


Lets keep it for now

AbhishekA1509 · 2026-02-17T06:50:26Z

src/components/workflowEditor/EmptyWorkflow.tsx

 import { FILTER_NAME_REGEX } from '../ApplicationGroup/Constants'
 import { NO_WORKFLOW_NAME, INVALID_WORKFLOW_NAME, MIN_3CHARS, MAX_30CHARS, SUCCESS_CREATION } from './constants'

 export default function EmptyWorkflow(props: EmptyWorkflowProps) {
+    const params = useParams<{ appId: string }>()


Could destructure here

AbhishekA1509 · 2026-02-17T06:50:45Z

src/components/workflowEditor/CreateWorkflow.tsx

-        }
-    }
+const AddWorkflow = ({ onClose, getWorkflows, isTemplateView }: AddWorkflowProps) => {
+    const params = useParams<{ appId: string; workflowId: string }>()


Here as well

AbhishekA1509 · 2026-02-17T07:23:35Z

src/components/v2/devtronStackManager/DevtronStackManager.component.tsx

+                                to={`${generatePath(ROUTER_URLS.INFRASTRUCTURE_MANAGEMENT_APP_DETAIL.EXTERNAL_HELM_APP, {
+                                    appId: `1|devtroncd|${appName}`,
+                                    appName
+                                })}/${URLS.APP_DETAILS}/${URLS.APP_DETAILS_K8}/pod/${logPodName}/logs`}


${generatePath(ROUTER_URLS.INFRASTRUCTURE_MANAGEMENT_APP_DETAIL.EXTERNAL_HELM_APP, { appId: 1|devtroncd|${appName}, appName })} This much part can be variable and reduced

AbhishekA1509 · 2026-02-17T07:25:57Z

src/components/v2/appDetails/NodeTreeDetailTab.tsx

+                        ].map((pathPattern) => (
+                            <Route
+                                key={pathPattern}
+                                path={pathPattern}


Does route not provide support for multiple paths?

not from v6

AbhishekA1509 · 2026-02-17T07:28:22Z

src/components/v2/appDetails/sourceInfo/EnvironmentSelector.component.tsx

@@ -250,47 +219,7 @@ const EnvironmentSelectorComponent = ({

                    <div className="fw-6 fs-14 cb-5">
                        <div style={{ minWidth: '200px' }}>
-                            {environments && environments.length > 0 && (


Is this and useEffects not required?

AbhishekA1509 · 2026-02-17T07:30:17Z

src/components/v2/appDetails/k8Resource/K8Resource.component.tsx

    const location = useLocation()
-    const { path } = useRouteMatch()
+    const path = location.pathname


This might be wrong since location would give live location

AbhishekA1509 · 2026-02-17T07:43:11Z

src/components/v2/appDetails/k8Resource/nodeType/NodeDelete.component.tsx

@@ -105,10 +104,10 @@ const NodeDeleteComponent = ({

    function describeNodeWrapper(tab) {
        queryParams.set('kind', params.podName)
-        const updatedPath = `${path.substring(0, path.indexOf('/k8s-resources/'))}/${
+        const updatedPath = `${location.pathname.substring(0, location.pathname.indexOf('/k8s-resources/'))}/${


Path and location are not interchangable, pls check once

AbhishekA1509 · 2026-02-17T07:44:17Z

src/components/v2/appDetails/k8Resource/nodeType/Node.component.tsx

@@ -153,7 +152,7 @@ const NodeComponent = ({
            setTableHeader(tableHeaders)

            // splitting with /group as group is present in application-group url as well
-            let [, _selectedResource] = url.split('/group/')
+            let [, _selectedResource] = location.pathname.split('/group/')


Pls check since it was coming from useRouteMatch

AbhishekA1509 · 2026-02-17T07:44:27Z

src/components/v2/appDetails/k8Resource/nodeType/Node.component.tsx

@@ -180,7 +179,7 @@ const NodeComponent = ({

            setSelectedHealthyNodeCount(_healthyNodeCount)
        }
-    }, [params.nodeType, podType, url, filteredNodes, podLevelExternalLinks])
+    }, [params.nodeType, podType, location.pathname, filteredNodes, podLevelExternalLinks])


AbhishekA1509 · 2026-02-17T07:44:44Z

src/components/v2/appDetails/k8Resource/nodeType/Node.component.tsx

@@ -221,7 +220,7 @@ const NodeComponent = ({
    }

    const handleActionTabClick = (node: iNode, _tabName: string, containerName?: string) => {
-        let [_url] = url.split('/group/')
+        let [_url] = location.pathname.split('/group/')


Here as well

AbhishekA1509 · 2026-02-17T09:43:32Z

src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetailTabs/Terminal.component.tsx

@@ -125,13 +125,13 @@ const TerminalComponent = ({
    }

    useEffect(() => {
-        selectedTab(NodeDetailTab.TERMINAL, url)
+        selectedTab(NodeDetailTab.TERMINAL, pathname)


Are these same?

AbhishekA1509 · 2026-02-17T09:44:55Z

src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetailTabs/Terminal.component.tsx

        handleAbort()
    }, [params.podName, params.name, params.namespace])

    useEffect(() => {
        if (showTerminal) {
-            selectedTab(NodeDetailTab.TERMINAL, `${url}/terminal`)
+            selectedTab(NodeDetailTab.TERMINAL, `${pathname}/terminal`)


AbhishekA1509 · 2026-02-17T10:00:59Z

src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetailTabs/Manifest.component.tsx

@@ -257,7 +256,7 @@ const ManifestComponent = ({
    }

    useEffect(() => {
-        selectedTab(NodeDetailTab.MANIFEST, url)
+        selectedTab(NodeDetailTab.MANIFEST, location.pathname)


pls check this

AbhishekA1509 · 2026-02-17T10:02:00Z

src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetailTabs/Logs.component.tsx

@@ -431,10 +435,16 @@ const LogsComponent = ({

    useEffect(() => {
        if (selectedTab) {
-            selectedTab(NodeDetailTab.LOGS, url)
+            selectedTab(NodeDetailTab.LOGS, location.pathname)


AbhishekA1509 · 2026-02-17T10:02:34Z

src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetailTabs/Events.component.tsx

    const [events, setEvents] = useState([])
    const [loading, setLoading] = useState(true)
    const appDetails = IndexStore.getAppDetails()

    useEffect(() => {
-        selectedTab(NodeDetailTab.EVENTS, url)
+        selectedTab(NodeDetailTab.EVENTS, location.pathname)


here as well

this will work fine

… and user experience

…upport nested routes

sonarqubecloud · 2026-02-19T10:53:20Z

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

arunjaindev added 3 commits February 9, 2026 17:03

Merge branch 'feat/react-18' of https://github.com/devtron-labs/dashb…

921a840

…oard into feat/react-router-v6

feat: upgrade react router to v6

34e0f0b

fix: lint issues

f7a524a

arunjaindev requested review from vikramdevtron and vivek-devtron as code owners February 13, 2026 11:41

arunjaindev added 3 commits February 13, 2026 17:20

chore: lint fixes

a97563d

chore: update dependencies in yarn.lock

236011e

fix: update route path to support nested routes in ResourceList

3a0e5e8

AbhishekA1509 requested a review from Copilot February 16, 2026 07:46

Copilot AI reviewed Feb 16, 2026

View reviewed changes

arunjaindev added 2 commits February 16, 2026 17:31

feat: refactor routing and components for improved workflow management

76c159d

fix: update SSO configuration reference to use correct property

e30bd41

AbhishekA1509 requested a review from Copilot February 16, 2026 12:55

AbhishekA1509 reviewed Feb 16, 2026

View reviewed changes

Copilot AI reviewed Feb 16, 2026

View reviewed changes

fix: update SSO configuration handling to correctly set SSO name and …

d04f788

…improve response parsing

AbhishekA1509 reviewed Feb 17, 2026

View reviewed changes

src/App.tsx

setGlobalAPITimeout(window._env_.GLOBAL_API_TIMEOUT)

}, [])

useEffect(() => {

Copy link

Member

AbhishekA1509 Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets keep it for now

AbhishekA1509 reviewed Feb 17, 2026

View reviewed changes

refactor: remove upgrade dialog logic and clean up CommandBar component

92f59da

AbhishekA1509 reviewed Feb 17, 2026

View reviewed changes

arunjaindev added 4 commits February 17, 2026 16:06

feat: enhance routing and component structure for improved navigation…

470e06e

… and user experience

feat: update routing for cluster listing

2451e8e

fix: login animation flicker

29e6184

feat: update routing for NodeDetails and ResourceList components to s…

82efbd2

…upport nested routes

Comments

Conversation

arunjaindev commented Feb 13, 2026

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 19, 2026

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants