Skip to content

Conversation

@kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Nov 4, 2025

Description

Fixes #

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Summary by Bito

  • This pull request introduces enhancements to the handling of password encryption by refactoring methods to utilize environment variables for encryption settings, ensuring sensitive data is securely managed.
  • The global configuration has been updated to include a new option for enabling password encryption, which is integrated into the dependency injection for various services.
  • The go.mod file has been updated to various dependencies, ensuring the project is using the latest versions, including updates to the 'authenticator' and 'common-lib' packages.
  • Overall, this pull request touches on configurations, dependencies, and security features, introducing risks related to sensitive data management and dependency updates.

vikramdevtron
vikramdevtron previously approved these changes Nov 4, 2025
@gitguardian
Copy link

gitguardian bot commented Nov 4, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
20952174 Triggered Username Password 1ee821c specs/template/configmap-secret-corrected.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2025

@kartik-579 kartik-579 merged commit 6f2f325 into develop Nov 4, 2025
6 checks passed
@kartik-579 kartik-579 deleted the main-sync-4nov-1 branch November 4, 2025 09:15
@bito-code-review
Copy link

Bito Review Skipped - No Changes Detected

Bito didn't review this pull request because we did not detect any changes in the pull request to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants