Skip to content

Add AppCenter analytics provider #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ky1vstar
Copy link

@ky1vstar ky1vstar commented Jan 15, 2021

This PR adds provider for Microsoft AppCenter analytics. Since AppCenter's API accepts [String: String] parameters (not [String: Any]) I decided to add associated type to RuntimeProviderType and give opportunity to its conformers to map parameters appropriately.

Aleksandr Zhuhan added 2 commits January 15, 2021 15:03
…derType (AppCenter analytics accepts [String: String] rather than [String: Any])
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #29 (8387f61) into master (9f7999c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #29   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           33        36    +3     
=========================================
+ Hits            33        36    +3     
Impacted Files Coverage Δ
Sources/Umbrella/RuntimeProviderType.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f7999c...8387f61. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant