CloundFoundry connector#1624
Conversation
47c7199 to
556cf89
Compare
|
Hi, just checking back. Since there is no feedback here yet so I am wondering are there certain requirements to meet for Dex to add a new connector? Is there a way to move forward for this PR or its just a simple Thank you for your time. |
|
Our team is also interested in this connector to adopt dex. |
|
@xtremerui This also has merge conflicts... 😄 |
efa3156 to
ed22ce5
Compare
526f2ed to
5549159
Compare
c7bbcf4 to
4e238e8
Compare
4e238e8 to
3f8cdd5
Compare
8d44c14 to
d2b321f
Compare
d2b321f to
7d9e841
Compare
7d9e841 to
f3d4b96
Compare
|
@sagikazarmark I kown there must be lots of pending PRs in your list. Just wanted to get some feedback here so we could move forward. Thx! We assume that a PR to dexidp/website to include the doc is needed. Then we will update README.md here. |
a4efbec to
73af7c0
Compare
73af7c0 to
75f4a22
Compare
75f4a22 to
fabca39
Compare
fabca39 to
5b5cd80
Compare
632cdf8 to
acc2c20
Compare
acc2c20 to
ee1e41e
Compare
7d0ae05 to
aa82d4f
Compare
6f2b2a0 to
014564c
Compare
014564c to
59511a0
Compare
|
I assume it fails because we changed the interface. |
|
@taylorsilva I assume we don't need Concourse to support Cloudfoundry anymore? Do we still looking to add this connector to Dex? |
|
We do still need this. Last big update was a year ago here: concourse#148 I get that Dex may not want this though. |
|
@taylorsilva, this is not the means of wanting something. We want all the connectors! We just don't have the capacity to support them all. I personally have no CloudFoundry in my space, and I do not know any real clients (which doesn't mean there are not any, I just don't know them). Which means neither I nor any other maintainers can effectively answer community questions regarding CloudFoundry. My desire is that instead of accepting all the connectors, give users the way to easily add their own connectors. |
… interface (dexidp#4589) The PKCE support added in v2.45.0 changed the CallbackConnector interface signatures but missed updating the authproxy and oauth connectors. This caused a type assertion failure in handleConnectorLogin(), resulting in "Requested resource does not exist" errors when using these connectors. Update LoginURL to return (string, []byte, error) and HandleCallback to accept a []byte connData parameter for both connectors and their tests. Signed-off-by: Mathias Gebbe <mathias.gebbe@gmail.com>
`groups` is a reserved word in MySQL >= 8.0.2, causing migration 13 to fail with a syntax error on `ALTER TABLE password ADD COLUMN groups`. Fixes dexidp#4579 Signed-off-by: Michiel De Backker <mail@backkem.me>
v2.45.1 prepare release
- Verifies user is part of orgs and spaces for group claims Signed-off-by: Joshua Winters <jwinters@pivotal.io> Co-authored-by: Shash Reddy <sreddy@pivotal.io>
Co-authored-by: Topher Bullock <tbullock@pivotal.io> Signed-off-by: Josh Winters <jwinters@pivotal.io>
Signed-off-by: Daniel Lavoie <dlavoie@live.ca>
Signed-off-by: Joshua Winters <jwinters@pivotal.io> Co-authored-by: Rui Yang <ryang@pivotal.io>
Co-authored-by: Rui Yang <ryang@pivotal.io> Signed-off-by: Joshua Winters <jwinters@pivotal.io>
Signed-off-by: Zoe Tian <ztian@pivotal.io> Co-authored-by: Ciro S. Costa <cscosta@pivotal.io> Signed-off-by: w3tian <w3tian@uwaterloo.ca>
Signed-off-by: Rui Yang <ryang@pivotal.io> Co-authored-by: Joshua Winters <jwinters@pivotal.io>
Signed-off-by: Joshua Winters <jwinters@pivotal.io> Co-authored-by: Rui Yang <ryang@pivotal.io>
gofumpt-ed Signed-off-by: Rui Yang <ryang@pivotal.io>
Signed-off-by: Rui Yang <ruiya@vmware.com>
Signed-off-by: Rui Yang <ruiya@vmware.com>
Signed-off-by: Rui Yang <ruiya@vmware.com>
Signed-off-by: Rui Yang <ruiya@vmware.com>
Signed-off-by: Kump3r <tonevkalin@gmail.com>
Signed-off-by: Kump3r <tonevkalin@gmail.com>
…ructure Signed-off-by: Kump3r <tonevkalin@gmail.com>
Signed-off-by: Kump3r <tonevkalin@gmail.com>
Signed-off-by: IvanChalukov <ichalukov@gmail.com>
Signed-off-by: Kump3r <tonevkalin@gmail.com>
Signed-off-by: Taylor Silva <dev@taydev.net>
59511a0 to
cc648ec
Compare
Support for authenticating against CloudFoundry
Documentation of CloudFoundry UAA server
cc @pivotal-jwinters