fix(oidc): verify userinfo sub matches the ID Token sub#4828
Open
kanywst wants to merge 1 commit into
Open
Conversation
createIdentity merged the userinfo response into the verified ID Token claims and read sub from the result, so a userinfo sub that differed from the ID Token sub became the subject. OpenID Connect Core 5.3.2 requires the two to match. Keep the ID Token sub before the merge and error on mismatch; skip the check when there is no ID Token (access-token token exchange). Signed-off-by: kanywst <niwatakuma@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Verify the userinfo
subagainst the ID Tokensubin the OIDC connector, as required by OpenID Connect Core 5.3.2.What this PR does / why we need it
With
getUserInfo: true,createIdentitymerged the userinfo response into the verified ID Token claims and readsubfrom the result, so a userinfosubthat differed from the ID Tokensubsilently became the subject (Identity.UserID). OpenID Connect Core 5.3.2 requires the two to match.This keeps the ID Token
subbefore the userinfo merge and returns an error on mismatch. When there is no ID Token (the access-token token exchange, where userinfo is itself the verification) the check is skipped, so that path is unchanged.Closes #4827
Special notes for your reviewer