feat: add logout confirmation page#4832
Open
Lutz-Pfannenschmidt wants to merge 1 commit into
Open
Conversation
Signed-off-by: maksim.nabokikh <max.nabokih@gmail.com> Signed-off-by: Lutz Pfannenschmidt <lutz.pfannenschmidt@proton.me>
Lutz-Pfannenschmidt
force-pushed
the
pr-logout-confirmation
branch
from
271b387 to
7f1769b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add a logout confirmation page when no id_token_hint is provided on GET /logout.
What this PR does / why we need it
Previously, GET /logout without an id_token_hint immediately logged the user out. Any cross-site image or link
<img src="/logout">could silently terminate a user's session.This PR adds a confirmation step: when id_token_hint is empty and the method is GET, a confirmation page is shown asking "Do you want to log out?" with a POST button. Only POST requests actually perform the logout. Logout with a valid id_token_hint is unaffected (proceeds immediately per OIDC spec).
Relates to #4560 (Implement Auth Sessions).
Special notes for your reviewer
The implementation follows the OIDC RP-Initiated Logout spec recommendation to require explicit user confirmation when the RP cannot identify the user session from the request.