expose TOTP setup key during enrollment - #4976
Open
slashmili wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Expose TOPT key during enrollment
What this PR does / why we need it
The idea is to allow showing TOTP code for users whom are not able to scan qr code or prefer to use the code in password managers.
I’m not changing the templates because downstream consumers such as NetBird provide their own web templates and own the presentation layer. This change only exposes the setup secret as TotpKey during unconfirmed TOTP enrollment, allowing those consumers to render a manual setup option alongside the QR code.