Skip to content

fix(dexie-cloud-addon): add .key/.primaryKey getters to createBlobResolvingCursor (fixes cursor crash) #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfahlander merged 1 commit into from
Apr 4, 2026
+14 −2
Merged

fix(dexie-cloud-addon): add .key/.primaryKey getters to createBlobResolvingCursor (fixes cursor crash) #2293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addons/dexie-cloud/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dexie-cloud-addon",
"version": "4.4.9",
"version": "4.4.10",
"description": "Dexie addon that syncs with to Dexie Cloud",
"type": "module",
"module": "dist/modern/dexie-cloud-addon.js",
Expand Down
14 changes: 13 additions & 1 deletion addons/dexie-cloud/src/middlewares/blobResolveMiddleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,20 @@ function createBlobResolvingCursor(
blobSavingQueue: BlobSavingQueue,
db: DexieCloudDB
): DBCoreCursor {
// Create wrapped cursor using Object.create() - inherits everything
// Create wrapped cursor using Object.create() - inherits everything.
// Important: .key and .primaryKey must be explicitly overridden with
// closure-based getters to prevent native IDBCursorWithValue getters from
// being reached through the prototype chain with a wrong `this`, which
// throws "Illegal invocation" in Chrome 146+.
const wrappedCursor = Object.create(cursor, {
key: {
get() { return cursor.key; },
configurable: true,
},
primaryKey: {
get() { return cursor.primaryKey; },
configurable: true,
},
value: {
value: cursor.value,
enumerable: true,
Expand Down
Loading