fix: Collection.sortBy() throws on frozen arrays in immutable cache mode

[liz709]

Problem

When using cacheMode: 'immutable', toArray() returns frozen arrays. Calling .sort() directly on a frozen array throws:

TypeError: Cannot assign to read only property '0' of object '[object Array]'

Fix

Use .slice().sort() to sort on a copy rather than mutating the original frozen array.

Fixes

Fixes #2157

Summary by CodeRabbit

• Bug Fixes
  • Fixed an issue where sorting operations would mutate the original array; the original data is now preserved.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 91ea7bf3-dfb3-470d-acb1-08fb4308f0ff

📥 Commits

Reviewing files that changed from the base of the PR and between 97f9942 and 07e45e5.

📒 Files selected for processing (1)

• src/classes/collection/collection.ts

---

📝 Walkthrough

Walkthrough

Updated Collection.sortBy() to create a shallow copy of the array via .slice() before sorting, preventing mutation of the original array. This enables the method to work with immutable cache mode where returned arrays are read-only.

Changes

Cohort / File(s)	Summary
Array Mutation Fix src/classes/collection/collection.ts	Modified Collection.sortBy() to sort a shallow copy of the array via .slice() instead of mutating the original, enabling compatibility with immutable cache mode.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A copy's made before we sort,
The frozen arrays come to port,
No mutations in immutable's way,
Our hopping code saves the day! 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the fix: using slice() to avoid mutating frozen arrays returned by toArray() in immutable cache mode.
Linked Issues check	✅ Passed	The code change directly addresses issue #2157 by fixing Collection.sortBy() to work with immutable cache mode through avoiding array mutations.
Out of Scope Changes check	✅ Passed	The change is narrowly scoped to the specific problem: replacing a.sort() with a.slice().sort() in Collection.sortBy() method only.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch liz/fix-sortby-immutable-cache

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}