security: add trusted_source warning for skopt.load() pickle deserialization#1
Open
dfgvaetyj3456356-hash wants to merge 2 commits into
Open
security: add trusted_source warning for skopt.load() pickle deserialization#1dfgvaetyj3456356-hash wants to merge 2 commits into
dfgvaetyj3456356-hash wants to merge 2 commits into
Conversation
Adds validation to reject path traversal sequences (..) in the yml_path parameter before opening the file. This prevents arbitrary file reads when user-controlled input is passed to Space.from_yaml().
…ization - joblib.load() uses pickle internally, enabling arbitrary code execution - Add trusted_source=False parameter with RuntimeWarning - Users must opt-in with trusted_source=True for untrusted files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a trusted_source parameter and warning for skopt.load() to address pickle deserialization security concerns.