-
Notifications
You must be signed in to change notification settings - Fork 427
Upgrading and cleaning up basic_bitcoin example #1135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kristoferlund
wants to merge
55
commits into
master
Choose a base branch
from
kristofer/bitcoin_basic_upgrade
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove bitcoin_api.rs as it just wraps the default bitcoin canister calls - introduces abstraction without purpose
instead of "raw" unbounded calls. * Replace local schnorr types with the ones defined in ic_cdk
serves no purpose.
should not be stored separately
Simplify naming and imports
for better readabilit and integration with dev docs
…led_address_script_spend.rs Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
…led_address_script_spend.rs Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
…led_address_key_spend.rs Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
Co-authored-by: Jessie Mongeon <[email protected]>
@dfinity/cross-chain-team FYI |
@dfinity/execution, this one should be good to go unless you have comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
256c45b5230b
— Upgrading dependencies, cleaning up, first takebitcoind
from project foldercustom
canister type withrust
type to allow for standarddfx deploy
ic_cdk
to v18 and as a consequence, changed a lot of management canister call signatures etc49bbff34e947
— Upgrade to ic_cdk 18bitcoin
dependency to0.32.5
introduces abstraction without purpose
92b72a36ea80
— Use management canister api calls instead of "raw" unbounded calls.ic_cdk::call::Call::unbounded_wait(super::mgmt_canister_id(), "sign_with_ecdsa")
becomesmanagement_canister::sign_with_ecdsa
, etc6176865f842e
— Rename to align with management canister namingbac595d71d81
— Storing a global, empty derivation path serves no purpose.a2f1f45b50ef
— "key_name" is a function of network and should not be stored separatelydab7b45b4de8
— Simplify ecdsa_public_key0b8917bfce2e
— Refactor, remove unnecessary subfolderbitcoin_wallet
as it serves no clear purpose. The whole project is about bitcoin wallets.2744f5d21997
— Cache Schnorr pubkeysff79ff6aa5ad
— Add support for Segwit address creation8cd2bc50aae1
— Refactor: Create individual service functions for better readability and integration with dev docsBitcoinContext
, a struct that is initialised on init and upgrade and can be passed around.533be3ff9e18
— Refactor: Naming, commentsc94d23aa0774
— Add support for p2wpkh sending1b841d12aca1
— Refactor: Remove manual sec1_to_der fn, etcSignature
provides the built insignature.serialize_der()
c826f4d9d682
— Adding a BIP-32 standard derivation path implementationInstead of using this very custom derivation scheme:
... use standard, BIP-32 derivation paths instead.
3d4355770922
— Refactor Taproot get_* functions for readability etcda976e270d76
— Exclude canister_ids from commit9fc8d46a3052
— Refactor send_from_key_path_only_address0ee09832e655
— Refactor, documentation790551d631be
— README