🔥 archive DIP based rust examples #1143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilbertt
reviewed
May 9, 2025
Member
ilbertt
left a comment
ilbertt
left a comment
There was a problem hiding this comment.
Why not keeping the DIP20 git submodule in the archived example, instead of copying the https://github.com/Psychedelic/DIP20 repo over here?
Contributor
Author
i just copy pasta'ed the whole folder, and thought that would work :D thanks for the catch! |
kristoferlund
approved these changes
May 9, 2025
ilbertt
approved these changes
May 12, 2025
viviveevee
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
These examples heavily rely on DIP standards which causes confusion in the ecosystem. Ideally we can replace them at some point with new, ICRC based examples.
Requirements
What requirements are necessary to consider this problem solved?
Considered Solutions
I tried to update them to the latest CDK and keep them but they're very much behind when it comes to best practices and libraries used that it's so much hassle it's probably better to just archive and rewrite them
Recommended Solution
What solution are you recommending? Why?
Considerations
What impact will this change have on security, performance, users (e.g. breaking changes) or the team (e.g. maintenance costs)?