feat: add account identifier + balance to neuron list.#21
Open
feat: add account identifier + balance to neuron list.#21
Conversation
The command to list neurons only returned the neuron IDs. This commit extends this information to include the account identifier as well as the balance of the neuron. The list of neurons are rendered in a table that looks like this: ``` npm run execute -- neuron list ╔════╤══════════════════════╤══════════════════════════════════════════════════════════════════╤═══════════════╗ ║ # │ Neuron ID │ Account Identifier │ Balance (e8s) ║ ╟────┼──────────────────────┼──────────────────────────────────────────────────────────────────┼───────────────╢ ║ 1 │ 123 │ XXXXX │ 123 ║ ╟────┼──────────────────────┼──────────────────────────────────────────────────────────────────┼───────────────╢ ║ 2 │ 456 │ XXXXX │ 123 ║ ╚════╧══════════════════════╧══════════════════════════════════════════════════════════════════╧═══════════════╝ ```
lmuntaner
reviewed
May 9, 2023
Contributor
lmuntaner
left a comment
lmuntaner
left a comment
There was a problem hiding this comment.
Thanks! Looks great!
I added a comment
| n.fullNeuron!.accountIdentifier | ||
| ); | ||
|
|
||
| const balance = await ledger.accountBalance({ |
Contributor
There was a problem hiding this comment.
Why don't you use cachedNeuronStake - neuronFees from the Neuron?
This way you'd avoid an extra call per neuron.
Collaborator
Author
There was a problem hiding this comment.
Because these are not necessarily accurate - there's a delay between that cached number and the real value, so we might as well get the real value. The calls to the ledger are quite cheap.
Contributor
There was a problem hiding this comment.
But a query call is not secure. Is that still better than the information in the neuron?
Or should we do an update call certified: true?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command to list neurons only returned the neuron IDs. This commit extends this information to include the account identifier as well as the balance of the neuron.
The list of neurons are rendered in a table that looks like this: