Conversation
mbjorkqvist
reviewed
Nov 19, 2025
| if (resp.returnCode == 28161) { | ||
| throw "Please open the Internet Computer app on your wallet and try again."; | ||
| } else if (resp.returnCode == LedgerError.TransactionRejected) { | ||
| } else if (resp.returnCode == 65535) { |
Contributor
Author
There was a problem hiding this comment.
Good point, done. I also changed all the codes to hexadecimal for better reference and add the link to the codes.
ielashi
reviewed
Nov 20, 2025
| public async getVersion(): Promise<Version> { | ||
| return this._executeWithApp(async (app: LedgerApp) => { | ||
| const res = await app.getVersion(); | ||
| // TODO: What would it mean if there is no version? Should we throw an error? |
Collaborator
There was a problem hiding this comment.
Should this be part of this change? It's not clear why it's needed, but in theory I'd rather crash/return an error if there is no version rather than return a version of zero.
Contributor
Author
There was a problem hiding this comment.
Good point, done!
lmuntaner
force-pushed
the
lm-test-icrc-txs
branch
from
0e56d6a to
67ddb80
Compare
ielashi
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.