chore: upgrade dependencies to @icp-sdk/canisters v3.2.0#73
Merged
Conversation
mducroux
changed the title
ielashi
approved these changes
Jan 8, 2026
Collaborator
ielashi
left a comment
ielashi
left a comment
There was a problem hiding this comment.
LGTM! Curious, why did we switch to esm build?
| @@ -60,7 +55,7 @@ | |||
| "ts-node": "^10.9.1" | |||
Collaborator
There was a problem hiding this comment.
Do we still need the ts-node dependency?
Contributor
Author
There was a problem hiding this comment.
Yes it is needed to run ./script/get-tokens-list.ts
Contributor
Author
|
Switching to ESM is not necessary actually. But since it is the modern best practice, I would suggest we can leave it as is. I don't think it makes a big difference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the various packages by switching to @icp-sdk/canisters v3.2.0 and @icp-sdk/core v5.0.0 as recommended here. Changes are as follows: