chore: Update to 2026-01-29-23-28#20
Merged
adamspofford-dfinity merged 3 commits intomainfrom Feb 4, 2026
Merged
Conversation
lwshang
requested changes
Feb 4, 2026
| if [[ "$v" =~ $reg ]]; then | ||
| pkgver=${BASH_REMATCH[1]} | ||
| icdate=${BASH_REMATCH[5]:-} | ||
| patchrel=${BASH_REMATCH[4]:-${BASH_REMATCH[7]:-}} |
Contributor
There was a problem hiding this comment.
patchrel is captured but never used.
Collaborator
Author
There was a problem hiding this comment.
I know, just putting it there in case we use it later
lwshang
approved these changes
Feb 4, 2026
lwshang
changed the title
lwshang
added a commit
that referenced
this pull request
Mar 27, 2026
Restore the ability to use dfinity/ic git commit hashes as version suffixes (e.g. 1.2.3-<40-hex-chars>), which was removed in PR #20. The script now handles three version formats: - plain: 1.2.3 - icdate: 1.2.3-2026-01-29-16-08 - git hash: 1.2.3-83c3f95e8c4ce28e02493df83df5f84a166451c0 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.