Skip to content

fix: implicit bitcoin and dogecoin setup when passing node addresses#22

Merged
marc0olo merged 1 commit intomainfrom
marc0olo/fix-implicit-bitcoin-and-dogecoin-setup
Feb 6, 2026
Merged

fix: implicit bitcoin and dogecoin setup when passing node addresses#22
marc0olo merged 1 commit intomainfrom
marc0olo/fix-implicit-bitcoin-and-dogecoin-setup

Conversation

@marc0olo
Copy link
Copy Markdown
Member

@marc0olo marc0olo commented Feb 6, 2026

Summary

Passing --bitcoind-addr or --dogecoind-addr did not fully set up the required environment. The bitcoin/dogecoin features were not enabled, so the bitcoin and dogecoin canisters were never deployed despite connecting to the nodes. Users had no way to enable these features through the CLI, making the flags effectively broken.

Additionally, --bitcoind-addr and --dogecoind-addr only accepted raw IP addresses (SocketAddr), which prevented using hostnames like bitcoind:18444 in Docker Compose setups.

Changes

  • Automatically enable bitcoin / dogecoin features in the ICP configuration when the respective node addresses are provided, so the canisters actually get deployed
  • Automatically enable the II subnet when bitcoin or dogecoin node addresses are provided, as it provides tECDSA signing keys commonly needed for Bitcoin/Dogecoin transactions
  • Explicitly create the bitcoin subnet when node addresses are provided for clarity
  • Change --bitcoind-addr and --dogecoind-addr from SocketAddr to String and resolve via DNS lookup at startup, enabling hostname support (e.g. Docker service names)

@marc0olo marc0olo requested a review from a team as a code owner February 6, 2026 15:32
@marc0olo marc0olo merged commit c93143f into main Feb 6, 2026
15 checks passed
@marc0olo marc0olo deleted the marc0olo/fix-implicit-bitcoin-and-dogecoin-setup branch February 6, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants