Conversation
adamspofford-dfinity
approved these changes
Feb 6, 2026
This was referenced Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Passing
--bitcoind-addror--dogecoind-addrdid not fully set up the required environment. The bitcoin/dogecoin features were not enabled, so the bitcoin and dogecoin canisters were never deployed despite connecting to the nodes. Users had no way to enable these features through the CLI, making the flags effectively broken.Additionally,
--bitcoind-addrand--dogecoind-addronly accepted raw IP addresses (SocketAddr), which prevented using hostnames likebitcoind:18444in Docker Compose setups.Changes
bitcoin/dogecoinfeatures in the ICP configuration when the respective node addresses are provided, so the canisters actually get deployed--bitcoind-addrand--dogecoind-addrfromSocketAddrtoStringand resolve via DNS lookup at startup, enabling hostname support (e.g. Docker service names)