Skip to content

feat: Lookup the target cargo directory#20

Merged
raymondk merged 1 commit intomainfrom
rk/more-robust-rust
Feb 17, 2026
Merged

feat: Lookup the target cargo directory#20
raymondk merged 1 commit intomainfrom
rk/more-robust-rust

Conversation

@raymondk
Copy link
Copy Markdown
Collaborator

  • Instead of moving the wasm, we simply copy it in order to avoid rebuilding unnecessarily
  • Lookup the cargo target path so we can tolerate cargo workspaces more easily

@raymondk raymondk requested a review from a team as a code owner February 15, 2026 01:23
@marc0olo
Copy link
Copy Markdown
Member

@raymondk FYI:

There is another nice side effect of the mvcp change: this also fixes a gzip compression failure on Linux.

cargo build can produce output files with multiple hard links (between target/.../release/ and target/.../deps/). mv on the same filesystem preserves the inode, so the moved file retains those hard links. The subsequent gzip --no-name step then fails with:

gzip: <file> has 1 other link -- unchanged

This only happens with GNU gzip (Linux) — BSD gzip (macOS) doesn't perform this check.

Switching to cp creates a fresh inode with link count 1, so gzip works without issues on both platforms.

@raymondk raymondk merged commit 2f79a27 into main Feb 17, 2026
5 checks passed
@raymondk raymondk deleted the rk/more-robust-rust branch February 17, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants