feat: Introduce explicit glob pattern handling for project manifest#13
Merged
feat: Introduce explicit glob pattern handling for project manifest#13
Conversation
…i-canister projects
rikonor
force-pushed
the
or-explicit-path
branch
from
065eeb6 to
9bcb41a
Compare
rikonor
force-pushed
the
or-explicit-path
branch
from
9bcb41a to
e23371a
Compare
…ts for single and multi-canister manifests
…fore parsing them into Utf8PathBuf values
ghost
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes it so that we don't treat potential glob patterns in canister paths as always explicit paths. Instead we simply treat them as strings and make a determination later if they're glob patterns or explicit paths.