Conversation
ilbertt
previously requested changes
Oct 14, 2025
rikonor
reviewed
Oct 14, 2025
rikonor
reviewed
Oct 14, 2025
rikonor
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is to remove the built in recipes so that we only rely on the recipe repository and there are minimal helpers in the icp cli.
For now, there are example recipes in the examples/ directory - they will need to be moved into https://github.com/dfinity/icp-cli-recipes.
The changes adds a hidden
icp project showcommand that prints out the manifest it could be used to test out that the recipes are getting computed properly.This will end up using: dfinity/icp-cli-recipes#3