Skip to content

feat: debug logs#139

Closed
ilbertt wants to merge 12 commits intomainfrom
luca/debug-logs
Closed

feat: debug logs#139
ilbertt wants to merge 12 commits intomainfrom
luca/debug-logs

Conversation

@ilbertt
Copy link
Copy Markdown
Contributor

@ilbertt ilbertt commented Oct 14, 2025 •
edited
Loading

Tested locally, this is what the output looks like when the --debug flag is enabled:

DEBUG icp: Starting icp-cli version="0+rev340282366920938463463374607431768211455.dirty-62d5900" git_sha="62d590076dd42998e4f0d5f9e47fe704451fd5d9" command=Deploy(Cmd { names: [], mode: "auto", subnet_id: None, controller: [], cycles: 2000000000000, identity: IdentityOpt { identity: None }, environment: EnvironmentOpt { environment: None, ic: false } })
INFO icp::progress: Fetching remote file: ...
...
INFO icp: Command executed successfully

Uses tracing for logging, and removes the console dependecy.

@ilbertt ilbertt marked this pull request as ready for review October 15, 2025 07:42
@ilbertt ilbertt requested a review from a team as a code owner October 15, 2025 07:42
viviveevee
viviveevee reviewed Oct 15, 2025
View reviewed changes
Comment thread crates/icp-cli/src/commands/mod.rs Outdated
Comment thread crates/icp-cli/src/progress.rs Outdated
@ilbertt ilbertt marked this pull request as draft October 15, 2025 08:42
@ilbertt ilbertt marked this pull request as ready for review October 15, 2025 10:25
@ilbertt ilbertt marked this pull request as draft October 15, 2025 16:43
@ilbertt ilbertt mentioned this pull request Oct 15, 2025
Merged
@ilbertt ilbertt closed this in #144 Oct 15, 2025
@ilbertt ilbertt deleted the luca/debug-logs branch October 15, 2025 18:27
rikonor pushed a commit that referenced this pull request Oct 15, 2025
@ilbertt
feat: debug logs (#144)
9010551 
Creates a custom TermWriter that prints to stdout only if the debug flag is set to false.

Disables progress bars on debug.

Adds a trace span with version and git hash, as well as an initial debug log.

Closes #139.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viviveevee viviveevee viviveevee approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ilbertt @viviveevee