Skip to content

chore: update recipe examples to point to the dfinity repo#141

Merged
raymondk merged 25 commits intomainfrom
recipe-type
Oct 17, 2025
Merged

chore: update recipe examples to point to the dfinity repo#141
raymondk merged 25 commits intomainfrom
recipe-type

Conversation

@raymondk
Copy link
Copy Markdown
Contributor

No description provided.

@raymondk raymondk requested a review from a team as a code owner October 15, 2025 02:40
Comment thread crates/icp/src/manifest/recipe.rs Outdated
Copy link
Copy Markdown
Contributor

@vincent-dfinity vincent-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the panic, looks good to me.

Comment thread crates/icp/src/manifest/recipe.rs Outdated
name: my-canister
recipe:
type: file://recipe.hb.yaml
type: "@dfinity/motoko"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could have an example for using a recipe from a local file, similar to how there's an example for a recipe from a remote url.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add that with: #142

Comment thread crates/icp/src/manifest/recipe.rs
@rikonor
Copy link
Copy Markdown
Contributor

rikonor commented Oct 16, 2025

Would be good to have tests for the following:

1. When trying to deserialize a canister manifest from a yaml string, the expected errors bubble up.
2. When trying to deserialize a project manifest from a yaml string with invalid canisters, the expected errors bubble up.

@raymondk raymondk marked this pull request as draft October 16, 2025 16:28
@raymondk raymondk marked this pull request as ready for review October 17, 2025 00:44
@raymondk raymondk merged commit b34dcb5 into main Oct 17, 2025
59 of 63 checks passed
@raymondk raymondk deleted the recipe-type branch October 17, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants