fix: prevent change listener leak in Vite plugin#110
Merged
viviveevee merged 3 commits intodfinity:mainfrom Feb 18, 2026
Merged
fix: prevent change listener leak in Vite plugin#110viviveevee merged 3 commits intodfinity:mainfrom
change listener leak in Vite plugin#110viviveevee merged 3 commits intodfinity:mainfrom
Conversation
Each call to `configureServer` (e.g. on Vite dev-server restart) added a new `change` listener without removing the previous one, eventually triggering Node's `MaxListenersExceededWarning`. Store a cleanup function in the plugin closure and call it at the start of each `configureServer` invocation so only one listener is active at a time. Add tests covering registration, cleanup, file filtering, and the `disableWatch` opt-out.
q-uint
changed the title
change listener leak in Vite plugin (#108)change listener leak in Vite plugin
Contributor
|
LGTM, thank you. The |
Contributor
Author
|
You're right, the Nix flake is unrelated. I'll drop it from this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each call to
configureServer(e.g. on Vite dev-server restart) added a newchangelistener without removing the previous one, eventually triggering Node'sMaxListenersExceededWarning.Store a cleanup function in the plugin closure and call it at the start of each
configureServerinvocation so only one listener is active at a time. Add tests covering registration, cleanup, file filtering, and thedisableWatchopt-out.Ref: #108