Closed
Conversation
ilbertt
suggested changes
Nov 12, 2025
Comment on lines
+63
to
+67
| didFile?: string; | ||
| /** | ||
| * | ||
| */ | ||
| didRemoteUrl?: string; |
Contributor
There was a problem hiding this comment.
How about we keep only one argument here and specify in the doc that it can be a local path or remote URL? Then, we can simply check in the implementation if it starts with http or https and perform the fetch
Contributor
There was a problem hiding this comment.
We should add tests for remote URLs here as well, but I can do it in a follow-up PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial draft to support non-file-based did generation.
service:candidfrom a canister directlyRef: #83
@ilbertt