Conversation
LXIF
previously requested changes
Apr 1, 2025
Contributor
LXIF
left a comment
LXIF
left a comment
There was a problem hiding this comment.
Looks good apart from typo in folder name!
| @@ -1,5 +1,5 @@ | |||
| import { callbackFlow } from "$src/flows/redirect"; | |||
| import { analytics, initAnalytics } from "$src/utils/analytics"; | |||
| import { analytics, initAnalytics } from "$src/utils/analyitcs/analytics"; | |||
Contributor
There was a problem hiding this comment.
Nit: please rename analyitcs to analytics.
sea-snake
reviewed
Apr 1, 2025
| @@ -1,5 +1,5 @@ | |||
| import { callbackFlow } from "$src/flows/redirect"; | |||
| import { analytics, initAnalytics } from "$src/utils/analytics"; | |||
| import { analytics, initAnalytics } from "$src/utils/analytics/analytics"; | |||
Contributor
There was a problem hiding this comment.
While we're at it, it might be nice to add an index.ts to the folder to re-export all folder content that should be used and available outside the folder.
Contributor
There was a problem hiding this comment.
Ah yes, good idea, I second this.
(was not aware initially of this pattern but it makes sense, similar to how it is done in rust)
Contributor
Author
There was a problem hiding this comment.
We agreed to do it as part of the new Svelte project structure.
sea-snake
approved these changes
Apr 1, 2025
lmuntaner
dismissed
LXIF’s stale review
Typo fixed. We will be changing the folder structure as part of the Svelte refactor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Funnels will be how we trigger events. That means we will create funnel instances.
To keep it maintainable I suggest we have them all under the same directory: "utils/analytics".
Changes
Tests
Only files moved.
🟡 Some screens were changed