Skip to content

Add login funnel#2984

Merged
lmuntaner merged 2 commits intomainfrom
lm-login-funnel
Apr 2, 2025
Merged

Add login funnel#2984
lmuntaner merged 2 commits intomainfrom
lm-login-funnel

Conversation

@lmuntaner
Copy link
Copy Markdown
Contributor

@lmuntaner lmuntaner commented Apr 2, 2025

Motivation

Create a funnel to track the user during logging from an application.

Changes

This pull request introduces significant enhancements to the login flow by integrating a new analytics funnel to track user interactions.

Key changes include:

Tests

Tested locally that events are triggered as expected along the login flow, but not registration (except the "start-login" which is expected to be triggered)


🟡 Some screens were changed

@lmuntaner lmuntaner requested a review from Copilot April 2, 2025 10:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds a new login funnel to standardize and improve logging of user interactions during the login process. Key changes include:

  • Creating a dedicated Funnel and LoginEvents in the analytics module.
  • Replacing several direct analytics event calls with loginFunnel trigger invocations across multiple files.
  • Initializing and integrating the login funnel in authentication flows and components.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/frontend/src/utils/iiConnection.ts Replaces analytics event calls with loginFunnel triggers for webauthn start events but removes error event logging.
src/frontend/src/utils/analytics/loginFunnel.ts Introduces the LoginEvents enum and a new loginFunnel instance for consistent tracking.
src/frontend/src/flows/authorize/postMessageInterface.ts Initializes the login funnel within the authentication protocol with a TODO to add origin data.
src/frontend/src/components/authenticateBox/index.ts Adds loginFunnel trigger calls for various user actions during the authentication flow.
Comments suppressed due to low confidence (1)

src/frontend/src/utils/iiConnection.ts:470

  • The logging for lookup errors has been removed without a corresponding loginFunnel trigger. Consider adding an appropriate error trigger to maintain consistent event tracking for failure scenarios.
analytics.event("login-passkey-error-lookup");

Comment thread src/frontend/src/flows/authorize/postMessageInterface.ts
@lmuntaner lmuntaner marked this pull request as ready for review April 2, 2025 10:11
@lmuntaner lmuntaner requested a review from sea-snake April 2, 2025 10:11
@lmuntaner lmuntaner assigned LXIF and unassigned LXIF Apr 2, 2025
@lmuntaner lmuntaner requested a review from LXIF April 2, 2025 10:19
Copy link
Copy Markdown
Contributor

@LXIF LXIF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lmuntaner lmuntaner added this pull request to the merge queue Apr 2, 2025
Merged via the queue into main with commit bb5f61f Apr 2, 2025
72 checks passed
@lmuntaner lmuntaner deleted the lm-login-funnel branch April 2, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants