Skip to content

Use origin on login and registration funnel#2985

Merged
lmuntaner merged 1 commit intomainfrom
lm-use-origin-in-funnels
Apr 2, 2025
Merged

Use origin on login and registration funnel#2985
lmuntaner merged 1 commit intomainfrom
lm-use-origin-in-funnels

Conversation

@lmuntaner
Copy link
Copy Markdown
Contributor

@lmuntaner lmuntaner commented Apr 2, 2025

Motivation

Enable filtering the funnel per application.

Changes

This pull request includes changes to improve the initialization of analytics funnels and the authentication protocol in the frontend code. The most important changes include initializing both loginFunnel and registrationFunnel with the request origin, and ensuring funnels are initialized in the manage flow (when user doesn't come from a dapp).

Improvements to analytics funnels:

Tests

Tested locally that events are triggered as expected.


🟡 Some screens were changed

@lmuntaner lmuntaner requested a review from Copilot April 2, 2025 14:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances analytics funnel initialization by incorporating the request origin into both login and registration funnels for the authentication protocol and adjusting their initialization in the manage flow.

  • Updated authenticationProtocol to pass the origin to both funnels.
  • Adjusted funnel initialization in the default (manage) flow to initialize without origin.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/frontend/src/index.ts Added loginFunnel import and updated funnel initialization order.
src/frontend/src/flows/authorize/postMessageInterface.ts Updated funnel initialization to pass the request origin.

@lmuntaner lmuntaner requested review from LXIF and sea-snake April 2, 2025 14:22
@lmuntaner lmuntaner marked this pull request as ready for review April 2, 2025 14:29
@lmuntaner lmuntaner added this pull request to the merge queue Apr 2, 2025
Merged via the queue into main with commit e408e24 Apr 2, 2025
72 checks passed
@lmuntaner lmuntaner deleted the lm-use-origin-in-funnels branch April 2, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants