Skip to content

Extra step to share Slack message with proposal #2987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmuntaner merged 1 commit into from
Apr 2, 2025
Merged

Extra step to share Slack message with proposal #2987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions scripts/make-upgrade-proposal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,11 @@ test_release_candidate() {
echo "Make sure to check various devices and ask others to also check"
}

share_proposal() {
echo "Share Proposal.md contents on Slack"
echo "Check that the arguments verification section matches the expected arguments."
}

confirm_proposal_arguments() {
echo "Confirm that the sha256 of the arg.bin file matches the one in the Proposal.md file"
echo ""
Expand Down Expand Up @@ -411,6 +416,7 @@ confirm_cmd append_proposal_argument
confirm_cmd deploy_release_candidate
confirm_manual "Confirm proposal arguments" confirm_proposal_arguments
confirm_manual "Test release candidate" test_release_candidate
confirm_manual "Share Proposal.md contents on Slack" share_proposal
confirm_cmd dry_run_proposal
confirm_manual "Review proposal" echo "Review the proposal above"
confirm_cmd make_proposal
Expand Down