Add JWT verification to OpenID Connect registration flow#2988
Merged
Conversation
…that checks that a faulty jwt will fail
lmuntaner
reviewed
Apr 2, 2025
sea-snake
approved these changes
Apr 3, 2025
sea-snake
reviewed
Apr 3, 2025
| registration::registration_flow_v2::identity_registration_finish( | ||
| CreateIdentityData::OpenID(arg), | ||
| ) | ||
| match verify(&arg.jwt, &arg.salt) { |
Contributor
There was a problem hiding this comment.
Only nitpick I can find is that I would have written openid::verify instead to make it more clear this is an openid verification and to avoid any future conflict with other methods that might be called verify.
sea-snake
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The ProdSec review had identified that we had missed to validate the OIDC JWT on
openid_identity_registration_finish. This PR corrects this oversight.Changes
Add the check to the endpoint, add integration Test
Tests
Added integration test.
🟡 Some screens were changed