Skip to content

chore: Re-enable Candid compatibility checks#3316

Closed
aterga wants to merge 1 commit intomainfrom
arshavir/re-enable-candid-checks
Closed

chore: Re-enable Candid compatibility checks#3316
aterga wants to merge 1 commit intomainfrom
arshavir/re-enable-candid-checks

Conversation

@aterga
Copy link
Copy Markdown
Collaborator

@aterga aterga commented Aug 27, 2025

Motivation

These checks were temporarily disabled in #3298

Changes

Uncommented interface-compatibility in .github/workflows/canister-tests.yml

Tests

Let's see

@aterga aterga requested review from Copilot and sea-snake August 27, 2025 11:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-enables Candid compatibility checks that were temporarily disabled in a previous pull request. The change restores the automated verification that ensures the Internet Identity canister interface remains compatible with the latest released version.

  • Re-enables the interface-compatibility GitHub Actions job
  • Restores automated Candid interface compatibility validation using didc

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@aterga aterga enabled auto-merge August 27, 2025 11:29
@aterga aterga force-pushed the arshavir/re-enable-candid-checks branch from 4d84781 to 9045d2e Compare November 19, 2025 16:16
@aterga
Copy link
Copy Markdown
Collaborator Author

aterga commented Mar 26, 2026

Closing this PR as stale — it has been open for ~7 months with no review activity. The Candid compatibility checks are still commented out in CI on main. If re-enabling them is still desired, a fresh PR against current main would be more appropriate since the CI workflow has likely evolved.


Generated by Claude Code

@aterga aterga closed this Mar 26, 2026
auto-merge was automatically disabled March 26, 2026 14:13

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants