Remove old google sign-in implementation.#3449
Merged
Conversation
…-in-implementation' into sea-snake/remove-old-google-sign-in-implementation
lmuntaner
reviewed
Oct 28, 2025
Contributor
lmuntaner
left a comment
lmuntaner
left a comment
There was a problem hiding this comment.
It must have been a nice PR to make!!
Minor comments
| openid_google: Some(Some(OpenIdGoogleConfig { | ||
| client_id: "https://example.com".into(), | ||
| })), | ||
| related_origins: Some(vec!["https://example.com".into()]), |
Contributor
Author
There was a problem hiding this comment.
This integration tests checks that config property A doesn't change when another property e.g. B is changed. Since B (openid_google) isn't available anymore, I switched to another random property C (related_origins).
| openid_google: Some(Some(OpenIdGoogleConfig { | ||
| client_id: "https://example.com".into(), | ||
| })), | ||
| enable_dapps_explorer: Some(true), |
Contributor
Author
There was a problem hiding this comment.
See above comment, couldn't use C here since it's the same property as A in this particular test file.
| openid_google: Some(Some(OpenIdConfig { | ||
| client_id: "https://example.com".into(), | ||
| })), | ||
| related_origins: Some(vec!["https://example.com".into()]), |
Contributor
Author
There was a problem hiding this comment.
See my other comment.
lmuntaner
approved these changes
Oct 28, 2025
sea-snake
deleted the
sea-snake/remove-old-google-sign-in-implementation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove old Google sign-in implementation since this has been superseded by the generic OpenID implementation.
Changes
openid_googleconfig and related state.openid/google.rs.setup_googlefromopenid.rs.openid_googleand related types from did file.OPENID_AUTHENTICATIONfeature flag since it's no longer used.integration/config/rate_limit.rsshould verifyregister_rate_limitinstead ofrelated_origins.integration/config/archive_config.rsshould verifyarchive_configinstead ofrelated_origins.Tests
Verified that II 1.0 and 2.0 work as expected, additionally e2e tests should pass.
🔴 Some screens were removed