Skip to content

Enable spanish and fix mobile language selector#3454

Merged
sea-snake merged 2 commits intomainfrom
sea-snake/enable-spanish-and-mobile-language-selector
Oct 31, 2025
Merged

Enable spanish and fix mobile language selector#3454
sea-snake merged 2 commits intomainfrom
sea-snake/enable-spanish-and-mobile-language-selector

Conversation

@sea-snake
Copy link
Copy Markdown
Contributor

@sea-snake sea-snake commented Oct 31, 2025

Enable spanish and fix mobile language selector.

Changes

  • Add Spanish to enabled languages.
  • Temporarily add LanguageSelectorFooter component.
    • Will be removed once Select component is available in a follow up PR.
    • Used to render language selection in page footer.
  • Fix chevron icon size for language selection on landing page (20px -> 16px).
  • Fix popover centering calculation for up direction.
  • Fix toggling summary icons on landing page in Safari

Tests

Verified that language can now be manually changed to Spanish and is automatically set on Spanish systems.

image image

Copy link
Copy Markdown
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It would have been nice to have two PRs, one to add the language another for the footer selector

@sea-snake sea-snake added this pull request to the merge queue Oct 31, 2025
Merged via the queue into main with commit 91c4e3a Oct 31, 2025
75 checks passed
@sea-snake sea-snake deleted the sea-snake/enable-spanish-and-mobile-language-selector branch October 31, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants