Skip to content

Add svelte-check to check script#3455

Merged
lmuntaner merged 1 commit intomainfrom
lm-svelte-check
Nov 3, 2025
Merged

Add svelte-check to check script#3455
lmuntaner merged 1 commit intomainfrom
lm-svelte-check

Conversation

@lmuntaner
Copy link
Copy Markdown
Contributor

@lmuntaner lmuntaner commented Nov 3, 2025

Motivation

Do not ship type errors to mainnet.

Changes

  • Add svelte-check check to the npm run check script.

Tests

  • Tested by adding a type error in one Svelte component and getting the fail on npm run check.

@lmuntaner lmuntaner marked this pull request as ready for review November 3, 2025 10:14
@lmuntaner lmuntaner requested a review from sea-snake November 3, 2025 10:14
Copy link
Copy Markdown
Contributor

@sea-snake sea-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmuntaner lmuntaner added this pull request to the merge queue Nov 3, 2025
Merged via the queue into main with commit cfaf18d Nov 3, 2025
76 checks passed
@lmuntaner lmuntaner deleted the lm-svelte-check branch November 3, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants