Skip to content

Update add/remove access method views.#3465

Merged
sea-snake merged 2 commits intomainfrom
sea-snake/update-access-method-views
Nov 4, 2025
Merged

Update add/remove access method views.#3465
sea-snake merged 2 commits intomainfrom
sea-snake/update-access-method-views

Conversation

@sea-snake
Copy link
Copy Markdown
Contributor

@sea-snake sea-snake commented Nov 4, 2025

Update add/remove access method views.

Changes

  • Remove Dialog wrapper from views.
  • Rename remove to unlink for OpenID view.
  • Make submission handlers in views promises and add loading state.
  • Localize labels and content.

Tests

Verified that adding/removing passkeys and OpenID credentials still works as expected.

@sea-snake sea-snake changed the title Update access method views. Update add/remove access method views. Nov 4, 2025
@sea-snake sea-snake requested a review from lmuntaner November 4, 2025 14:15
Copy link
Copy Markdown
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sea-snake sea-snake added this pull request to the merge queue Nov 4, 2025
Merged via the queue into main with commit 4ebc8e4 Nov 4, 2025
75 checks passed
@sea-snake sea-snake deleted the sea-snake/update-access-method-views branch November 4, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants