Merged
Conversation
…s for css size overrides without !important.
lmuntaner
approved these changes
Nov 5, 2025
Contributor
lmuntaner
left a comment
lmuntaner
left a comment
There was a problem hiding this comment.
Minor comment, already approving.
Contributor
There was a problem hiding this comment.
Where is this icon used? Can't we remove it?
Contributor
Author
There was a problem hiding this comment.
Yeah, we can probably remove it. I'll do a PR to cleanup this and other related unused things after the access methods (so it's just a single delete files PR).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use class for custom icon dimensions instead of size prop, this allows for css size overrides without !important e.g.
!size-6in tailwind.Tests
The size prop wasn't used yet, so no other changes were needed.