Add behavior when entering recovery words#3471
Merged
Conversation
Contributor
Author
|
New UX: Screen.Recording.2025-11-04.at.14.01.04.mov |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds password masking functionality to the recovery phrase input page to enhance security and privacy when entering recovery words. The implementation includes show/hide toggles for individual inputs and all inputs collectively, along with password manager ignore attributes and lowercase normalization.
Key changes:
- Added password masking for recovery phrase inputs with per-field and global show/hide controls
- Implemented lowercase normalization on input to ensure consistent word validation
- Added password manager ignore attributes to prevent interference
Comments suppressed due to low confidence (1)
src/frontend/src/routes/(new-styling)/recovery-phrase/+page.svelte:138
- Corrected spelling of 'Uses' to 'Users'.
// Uses might paste text with multiple spaces, tabs, or newlines between words.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Improve the user experience during entering the recovery phrase.
Changes
This pull request enhances the recovery phrase entry page by improving user privacy and usability. The main changes introduce per-word and global visibility toggling for recovery phrase inputs, enforce lowercase input, and add a "Clear all" option. These updates help protect sensitive information from shoulder surfing and password managers, while making the input process smoother and more intuitive.
Recovery phrase input privacy and usability improvements:
showContentproperty to each recovery word and a globalshowAllstate to control visibility of word inputs. Inputs are now masked by default (typepassword), and can be revealed individually (on focus) or all at once via a "Show all"/"Hide all" toggle.data-lpignore,autocomplete="off", etc.).Tests
Tested locally, see videos attached.